salt icon indicating copy to clipboard operation
salt copied to clipboard

Set system.set_reboot_required_witnessed to use /tmp/salt

Open tqre opened this issue 4 years ago • 4 comments

Fixes #58125

Removed the depends-decorator as it was not functioning correctly. The file was touched always in the NILinuxRT -specific directory. Made a simple check for the os_family instead. Also added clarification on module functionality on setting the reboot flag. Renamed the file created to be more precise on it's meaning.

Commits signed with GPG?

No

tqre avatar Aug 04 '20 22:08 tqre

Found a typo and removed the unused import. However, I'm not sure what is the correct string formatting here, I changed it according to https://docs.saltstack.com/en/latest/topics/development/conventions/style.html#formatting-strings

tqre avatar Sep 16 '20 17:09 tqre

Since this doesn't have a test case, dropping it from the scope for the Magnesium release.

sagetherage avatar Oct 06 '20 17:10 sagetherage

Is there anything that can be done to un-block this?

mdschmitt avatar Aug 08 '22 04:08 mdschmitt

This PR requires a test case, a changelog file and looks like previously pre-commit was failing.

Ch3LL avatar Aug 08 '22 19:08 Ch3LL

Anyone willing to push this one to completion?

Ch3LL avatar Nov 04 '22 18:11 Ch3LL

Closing due to inactivity. Please let me know if you want me to re-open this PR or open a new PR against the master branch including the feedback in the PR

Ch3LL avatar Nov 21 '22 19:11 Ch3LL