salt-ext-modules-vmware
salt-ext-modules-vmware copied to clipboard
Use `name` for the primary id of VMC states
VMC is currently using name
for salt logging and not much else.
In salt it's normal for name
in state functions to be the static identifier for the object being modified. Something like the file name you are chmod-ing, or the host you are checking for connectivity, or the command line string you are executing.
As an example, right now we have dhcp_profile_id
as well as name
.
We need to delete dhcp_profile_id
from the function argument list, replacing its usages with name
, then update the docstring of name
to be something like: The dhcp profile id, any static unique string identifying the rule. Also used for the display_name by default.