salt-ext-modules-vmware icon indicating copy to clipboard operation
salt-ext-modules-vmware copied to clipboard

Use `name` for the primary id of VMC states

Open dhiltonp opened this issue 3 years ago • 1 comments

VMC is currently using name for salt logging and not much else.

In salt it's normal for name in state functions to be the static identifier for the object being modified. Something like the file name you are chmod-ing, or the host you are checking for connectivity, or the command line string you are executing.

As an example, right now we have dhcp_profile_id as well as name.

We need to delete dhcp_profile_id from the function argument list, replacing its usages with name, then update the docstring of name to be something like: The dhcp profile id, any static unique string identifying the rule. Also used for the display_name by default.

dhiltonp avatar Oct 13 '21 15:10 dhiltonp