salt-bootstrap
salt-bootstrap copied to clipboard
[WIP] Added support for Amazon 2023, Debian 11 & 12, removed EOL OSs and Python 2.7 support
What does this PR do?
Adds support for Amazon 2023, Debian 11 and 12. Removes support for Debian 7, 8 & 9, RHEL 6, Amazon Linux (RHEL 6 clone) and Python 2.7
What issues does this PR fix or reference?
Fixes: https://github.com/saltstack/salt-bootstrap/issues/1940, https://github.com/saltstack/salt-bootstrap/issues/1986
Previous Behavior
Amazon 2023, Debian 11 and 12 failed to install with bootstrap script
New Behavior
Amazon 2023, Debian 11 and 12 now install with bootstrap script. Debian 7, 8 and 9, RHEL 6, Amazon Linux (RHEL 6 clone) and Python 2.7 are no longer supported
Cleaned up script with shellcheck before removing the EOL OS and Python 2.7 support.
Ensure the bootstrap script works on Centosstream 8 with redhat-lsb-core installed, it might be affecting distro
CI indicates this is failing with Failed to run install_debian_onedir_deps()!!!, without any visible Error message.
Do we know why this is failing?
@Foorack WIP - Work In Progress, read the title. Still have to implement GitHub Actions runners
Note: nightly workflow directory structure has changed and needs adjustment in the bootstrap script, for example: https://repo.saltproject.io/salt-dev/3006.x/latest/salt/py3/photon/4.0/x86_64/ etc. and that latest could be replaced by a date, that is, https://repo.saltproject.io/salt-dev/3006.x/2024-07-02/salt/py3/photon/4.0/x86_64/minor/
Having issues with Centos Stream 8
david@david-XPS-15-9570:~$ docker run -it --rm --net=host quay.io/centos/centos:stream8
Unable to find image 'quay.io/centos/centos:stream8' locally
stream8: Pulling from centos/centos
3ca969c7b6d7: Pull complete
Digest: sha256:20da069d4f8126c4517ee563e6e723d4cbe79ff62f6c4597f753478af91a09a3
Status: Downloaded newer image for quay.io/centos/centos:stream8
[root@david-XPS-15-9570 /]# yum update
Failed to set locale, defaulting to C.UTF-8
CentOS Stream 8 - AppStream 0.0 B/s | 0 B 00:02
Errors during downloading metadata for repository 'appstream':
- Curl error (6): Couldn't resolve host name for http://mirrorlist.centos.org/?release=8-stream&arch=x86_64&repo=AppStream&infra=container [Could not resolve host: mirrorlist.centos.org]
Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: Curl error (6): Couldn't resolve host name for http://mirrorlist.centos.org/?release=8-stream&arch=x86_64&repo=AppStream&infra=container [Could not resolve host: mirrorlist.centos.org]
[root@david-XPS-15-9570 /]# exit
Cannot even get a docker container locally, and then this https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/ so Centos Stream 8 is EOL as of Mat 31, 2024
Wondering if should just remove Centos Stream 8 since EOL
Photon OS 4 has git install issues with the compiler
2024-07-03T21:29:35.7709169Z self.initialize_options()
2024-07-03T21:29:37.9135494Z /usr/lib/python3.10/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
2024-07-03T21:29:37.9136909Z !!
2024-07-03T21:29:37.9137295Z
2024-07-03T21:29:37.9137763Z ********************************************************************************
2024-07-03T21:29:37.9138529Z Please avoid running ``setup.py`` directly.
2024-07-03T21:29:37.9139530Z Instead, use pypa/build, pypa/installer or other
2024-07-03T21:29:37.9140329Z standards-based tools.
2024-07-03T21:29:37.9140848Z
2024-07-03T21:29:37.9141775Z See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
2024-07-03T21:29:37.9142837Z ********************************************************************************
2024-07-03T21:29:37.9143478Z
2024-07-03T21:29:37.9143818Z !!
2024-07-03T21:29:37.9144217Z self.initialize_options()
2024-07-03T21:29:37.9803124Z x86_64-unknown-linux-gnu-gcc: fatal error: cannot execute 'as': execvp: No such file or directory
2024-07-03T21:29:37.9804014Z compilation terminated.
2024-07-03T21:29:37.9819795Z error: Setup script exited with error: command '/usr/bin/x86_64-unknown-linux-gnu-gcc' failed with exit code 1
2024-07-03T21:29:38.0412963Z + return 1
2024-07-03T21:29:38.0415365Z + echoerror 'Failed to run install_photon_git()!!!'
2024-07-03T21:29:38.0417639Z + printf '\033[1;31m * ERROR\033[0m: %s\n' 'Failed to run install_photon_git()!!!'
2024-07-03T21:29:38.0419521Z [1;31m * ERROR[0m: Failed to run install_photon_git()!!!
Running into issue with Amazon 2023 with current stable version Ruby 3.3.4 for Create Test Instance, reverting to original 2.6.10
11s
Run ## DGM Need to replace this
-----> Starting Test Kitchen (v3.6.0)
-----> Creating <stable-3006-amazon-2023>...
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: [1](https://github.com/saltstack/salt-bootstrap/actions/runs/9882490882/job/27295489413?pr=1987#step:6:1) actions failed.
>>>>>> Create failed on instance <stable-3006-amazon-2023>. Please see .kitchen/logs/stable-3006-amazon-2023.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
Error: Process completed with exit code 20.