salt-bootstrap icon indicating copy to clipboard operation
salt-bootstrap copied to clipboard

Fix issue 1930 and issue 1931

Open schories opened this issue 2 years ago • 2 comments

What does this PR do?

Fixes 2 bugs/issues:

  1. bootstrap-salt.sh repo based installation on CentOS/AlmaLinux/RockyLinux/etc. now setting correct repo URLs again, as _ONEDIR_DIR was missing
  2. daemons_running in bootstrap-salt.sh now also works for AlmaLinux 9, while keeping backward compatibility with older distro releases/versions of CentOS/AlmaLinux/RockyLinux/etc.

What issues does this PR fix or reference?

Fixes: https://github.com/saltstack/salt-bootstrap/issues/1930 Fixes: https://github.com/saltstack/salt-bootstrap/issues/1931

schories avatar May 24 '23 09:05 schories

I'd like to thank Mr. Heiko Kowall for his instant and outstanding support & advice, making this PR possible. Thank you!

schories avatar May 24 '23 09:05 schories

@schories Thanks for the PR. In reviewing the changes, the function you're updating to include references to ONEDIR is the function that is used for the non-onedir packages. There are functions that are handling installing the RHEL repos and ensuring that the daemons are running for the ONEDIR packages. These functions include the correct references.

garethgreenaway avatar Jun 25 '23 19:06 garethgreenaway