pepper icon indicating copy to clipboard operation
pepper copied to clipboard

validate is broken if salt is not installed.

Open ldav1s opened this issue 5 years ago • 4 comments

ldav1s avatar Jan 31 '20 01:01 ldav1s

Howdy! :wave:

Apologies for the long delay on this integrating this code. We certainly appreciate your effort!

Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met.

If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR.

If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR.

Thank you, and we hope to see you active in the Salt ecosystem in the future!

nicholasmhughes avatar Apr 20 '23 19:04 nicholasmhughes

I think this branch is up to date with the develop branch of pepper.

ldav1s avatar Apr 26 '23 02:04 ldav1s

@ldav1s - thanks for responding. I've just finished fixing the test suite and migrating it to Github Actions. Would you be able to update your branch now please?

Could you also add some tests? If you need some help with that, please let me know.

Thanks very much!

barneysowood avatar May 02 '23 17:05 barneysowood

Could you also add some tests? If you need some help with that, please let me know.

I'd have to have some kind of special environment or something to keep salt.loader, salt.config, and salt.output from being imported while under test.

ldav1s avatar May 06 '23 16:05 ldav1s