prometheus-formula icon indicating copy to clipboard operation
prometheus-formula copied to clipboard

feat(archive): allowing archive options to be overridable

Open corey-hammerton opened this issue 2 years ago • 0 comments

PR progress checklist (to be filled in by reviewers)

  • [x] Changes to documentation are appropriate (or tick if not required)
  • [x] Changes to tests are appropriate (or tick if not required)
  • [ ] Reviews completed

What type of PR is this?

Primary type

  • [ ] [build] Changes related to the build system
  • [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ ] [ci] Changes to the continuous integration configuration
  • [x] [feat] A new feature
  • [x] [fix] A bug fix
  • [ ] [perf] A code change that improves performance
  • [ ] [refactor] A code change that neither fixes a bug nor adds a feature
  • [ ] [revert] A change used to revert a previous commit
  • [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [ ] [docs] Documentation changes
  • [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

  • fix(usernames): Truncating user/group names to 32 characters (linux limit)
  • feat(archive): Allowing archive options to be overridable

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • [ ] Updated the README (e.g. Available states).
  • [ ] Updated pillar.example.

Testing checklist

  • [x] Included in Kitchen (i.e. under state_top).
  • [x] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • [ ] Updated the relevant test pillar.

Additional context

corey-hammerton avatar Sep 02 '22 14:09 corey-hammerton