prometheus-formula icon indicating copy to clipboard operation
prometheus-formula copied to clipboard

Fix textfile collector installation

Open WiiPlayer2 opened this issue 2 years ago • 1 comments

PR progress checklist (to be filled in by reviewers)

  • [ ] Changes to documentation are appropriate (or tick if not required)
  • [ ] Changes to tests are appropriate (or tick if not required)
  • [ ] Reviews completed

What type of PR is this?

Primary type

  • [ ] [build] Changes related to the build system
  • [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ ] [ci] Changes to the continuous integration configuration
  • [ ] [feat] A new feature
  • [x] [fix] A bug fix
  • [ ] [perf] A code change that improves performance
  • [ ] [refactor] A code change that neither fixes a bug nor adds a feature
  • [ ] [revert] A change used to revert a previous commit
  • [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [ ] [docs] Documentation changes
  • [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The installation of textfile collectors is currently not part of testing which probably resulted in the installation being broken without realizing. This PR fixes template and installation issues regarding the textfile_collectors state and the provided collectors in this repository.

Pillar / config required to test the proposed changes

When running the kitchen tests, enable a collector in the pillar, and test e.g. debian-11-3004-0-py3

prometheus:
  exporters:
    node_exporter:
      textfile_collectors:
        ipmitool:
          enable: true

Debug log showing how the proposed changes work

Documentation checklist

  • [ ] Updated the README (e.g. Available states).
  • [ ] Updated pillar.example.

Testing checklist

  • [ ] Included in Kitchen (i.e. under state_top).
  • [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • [ ] Updated the relevant test pillar.

Additional context

Due to pillar key prometheus:exporters:node_exporter:textfile_collectors_dependencies being set to [] in the test pillar data, it overwrites the provided values for Debian in osfamilymap.yaml. To fully test this PR all OS families should declare the necessary textfile collector dependencies and the key should then be removed from the test pillar data.

WiiPlayer2 avatar Mar 13 '22 14:03 WiiPlayer2