graphite-formula icon indicating copy to clipboard operation
graphite-formula copied to clipboard

whisper directory perms should only be set on create

Open iggy opened this issue 11 years ago • 3 comments

https://github.com/saltstack-formulas/graphite-formula/blob/master/graphite/init.sls#L86

If you have data already in that directory, the recurse can take forever.

iggy avatar Jan 22 '15 22:01 iggy

Fair point - shouldn't we just get rid of that statement altogether?

sroegner avatar Jan 26 '15 12:01 sroegner

I was thinking something like the following. I don't know how much of the shell is available for onlyif calls though (or I would have just done a PR ;) onlyif: [ ! -d {{ whisperdir }} ]

iggy avatar Jan 26 '15 16:01 iggy

That would work but looking at the code again i'd think we'll just have to get rid of the recurse attribute - then it should only create the whisper dir if needed but nothing more. Will need to get a test setup together for this - if you need this expedited you can send me a PR.

sroegner avatar Jan 27 '15 13:01 sroegner