firewalld-formula icon indicating copy to clipboard operation
firewalld-formula copied to clipboard

feat(policies): add policies management

Open kartnico opened this issue 1 year ago • 1 comments

PR progress checklist (to be filled in by reviewers)

  • [ ] Changes to documentation are appropriate (or tick if not required)
  • [ ] Changes to tests are appropriate (or tick if not required)
  • [ ] Reviews completed

What type of PR is this?

Primary type

  • [ ] [build] Changes related to the build system
  • [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ ] [ci] Changes to the continuous integration configuration
  • [X] [feat] A new feature
  • [ ] [fix] A bug fix
  • [ ] [perf] A code change that improves performance
  • [ ] [refactor] A code change that neither fixes a bug nor adds a feature
  • [ ] [revert] A change used to revert a previous commit
  • [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [ ] [docs] Documentation changes
  • [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Manage Firewalld policies.

A new feature, policy objects, will be part of the firewalld feature release (v0.9.0). This is a major feature that has been in the works for almost a full year. It is significant because it closes one of the long standing gaps in firewalld’s functionality: forward and output filtering.

Pillar / config required to test the proposed changes

See pillar.example.

Debug log showing how the proposed changes work

Documentation checklist

  • [ ] Updated the README (e.g. Available states).
  • [X] Updated pillar.example.

Testing checklist

  • [ ] Included in Kitchen (i.e. under state_top).
  • [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • [ ] Updated the relevant test pillar.

Additional context

https://firewalld.org/2020/09/policy-objects-introduction https://firewalld.org/documentation/man-pages/firewalld.policy.html

kartnico avatar Mar 12 '23 13:03 kartnico

This feature looks nice. Thank you for implementing this. Do you think you would be able to ad some inspec tests for the policy module to the right files in https://github.com/saltstack-formulas/firewalld-formula/tree/master/test/integration/default/files/_mapdata? That would give us a bit of testing coverage for your change.

ixs avatar Jun 20 '24 21:06 ixs