elasticsearch-formula icon indicating copy to clipboard operation
elasticsearch-formula copied to clipboard

[BUG] path.data does not support lists

Open darkpixel opened this issue 5 years ago • 1 comments

Elasticsearch docs support multiple data paths.

The path.data settings can be set to multiple paths, in which case all paths will be used to store data (although the files belonging to a single shard will all be stored on the same data path):

path:
  data:
    - /mnt/elasticsearch_1
    - /mnt/elasticsearch_2
    - /mnt/elasticsearch_3

See: https://www.elastic.co/guide/en/elasticsearch/reference/master/path-settings.html

Attempting to use a list produces the following output:

[CRITICAL] Rendering SLS 'base:elasticsearch.config' failed: while constructing a mapping
  in "<unicode string>", line 1, column 1:
    include:
    ^
found unacceptable key [ScalarNode(tag='tag:yaml.org,2002:str', value='/usr/shar
  in "<unicode string>", line 17, column 1:
    ['/usr/share/elasticsearch/data' ... 
    ^
local:
    Data failed to compile:
----------
    Rendering SLS 'base:elasticsearch.config' failed: while constructing a mappi
  in "<unicode string>", line 1, column 1:
    include:
    ^
found unacceptable key [ScalarNode(tag='tag:yaml.org,2002:str', value='/usr/shar
  in "<unicode string>", line 17, column 1:
    ['/usr/share/elasticsearch/data' ... 
    ^

darkpixel avatar Nov 06 '19 16:11 darkpixel

Thanks for the report @darkpixel.

Relevant parts of the formula to be adjusted:

https://github.com/saltstack-formulas/elasticsearch-formula/blob/dea47030b460779e7d11690887fd19539da623cb/pillar.example#L8-L9

  • Need to show an example of path.data provided as a list as well.

https://github.com/saltstack-formulas/elasticsearch-formula/blob/2cbe705c0ff37ec2b8131b5b8e15534d71863a97/elasticsearch/config.sls#L15-L19

  • Merge everything together into a single list to iterate over.

myii avatar Nov 06 '19 16:11 myii