django-formula icon indicating copy to clipboard operation
django-formula copied to clipboard

django-formula: next generation

Open bebosudo opened this issue 6 years ago • 13 comments

Hi all, I wrote another django-formula, which provides more options to customize a django webapp. Moreover, I wrote a working example of deployment.

https://github.com/bebosudo/django-formula/ https://groups.google.com/forum/#!topic/salt-users/rMeG9VirEns

I propose to add it as a ng version, as in the postgres-formula. What do you think?

bebosudo avatar Oct 25 '18 22:10 bebosudo

@bebosudo sorry to see this issue, so late...

Will look into it.

aboe76 avatar Feb 14 '19 22:02 aboe76

Hi @aboe76, I'd like to extend the example further with a pipenv section. Feel free to comment my fork.

bebosudo avatar Feb 14 '19 23:02 bebosudo

@aboe76 any news?

bebosudo avatar Feb 19 '19 15:02 bebosudo

@bebosudo Please continue your good work. We're making substantial changes across all SaltStack Formulas right now, to improve the quality and consistency of formulas. For example of some of the changes we're working through, please see https://github.com/saltstack-formulas/template-formula/issues/21.

Once we've managed to start applying automatic release tagging and the other basic structures, we can look at how to incorporate ng formulas. For another example of a formula working towards this, refer to the conversation surrounding the comment: https://github.com/saltstack-formulas/apache-formula/pull/251#issuecomment-464841346.

myii avatar Feb 19 '19 16:02 myii

@bebosudo, @myii is right, we are changing the saltstack-formulas hopefully for the better to accomodate these kind of changes, with semver solution, instead of ng

aboe76 avatar Feb 19 '19 19:02 aboe76

@aboe76 Our changes are going to take some time, perhaps we should put this in a new develop-v1.0.0 branch, like has been done for the apache-formula? One other thought about this (for both formulas) -- don't we want to set this new branch as the default, so that PRs are provided for the new branch?

myii avatar Mar 29 '19 18:03 myii

@myii I see no problem with that.

aboe76 avatar Mar 30 '19 20:03 aboe76

Thanks, @aboe76. @bebosudo OK, I've created that branch. Feel free to "replace" it with your formula in a new PR.

myii avatar Mar 30 '19 20:03 myii

@bebosudo Are you still interesting in providing this? We could continue with the branch or we could even implement semantic-release in this formula, to make it available immediately.

  • https://github.com/saltstack-formulas/.github/blob/master/CONTRIBUTING.rst#semantic-release-formulas
    • Look further up in that document for an explanation of what semantic-release is

myii avatar Nov 23 '19 17:11 myii

Hi, I'm still interested in developing that formula; I'll try to find time this week.

bebosudo avatar Nov 25 '19 11:11 bebosudo

@bebosudo Thanks, I'll try to get semantic-release implemented before then, so that we can have a cleaner conversion.

myii avatar Nov 25 '19 12:11 myii

@bebosudo OK, semantic-release has been merged in #9 and I've removed the extra branch develop-v1.0.0. I'll start the deprecation notices soon, so that any existing users are informed that the formula is about to be significantly modified.

myii avatar Nov 25 '19 20:11 myii

Another reason to get the current formula replaced: #11.

myii avatar Dec 09 '19 08:12 myii