bind-formula icon indicating copy to clipboard operation
bind-formula copied to clipboard

feat: allow customization of a postrotate script

Open ekacnet opened this issue 2 years ago • 1 comments

You need to signal to bind to reload log files after rotating them, doing rndc reconfig is a good way of doing so.

This change allows you to actually have that in the generated logrotate configuration

PR progress checklist (to be filled in by reviewers)

  • [ ] Changes to documentation are appropriate (or tick if not required)
  • [ ] Changes to tests are appropriate (or tick if not required)
  • [ ] Reviews completed

What type of PR is this?

Primary type

  • [ ] [build] Changes related to the build system
  • [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ ] [ci] Changes to the continuous integration configuration
  • [X] [feat] A new feature
  • [ ] [fix] A bug fix
  • [ ] [perf] A code change that improves performance
  • [ ] [refactor] A code change that neither fixes a bug nor adds a feature
  • [ ] [revert] A change used to revert a previous commit
  • [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [X] [docs] Documentation changes
  • [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Allow the logrotate config to have a postrotate script. When using logrotate without telling bind to reload, it will continue to write to the same file.

Pillar / config required to test the proposed changes

logrotate: postrotate_script: > rndc reconfig &>/dev/null || true

Debug log showing how the proposed changes work

Documentation checklist

  • [ ] Updated the README (e.g. Available states).
  • [X] Updated pillar.example.

Testing checklist

  • [ ] Included in Kitchen (i.e. under state_top).
  • [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • [ ] Updated the relevant test pillar.

Additional context

ekacnet avatar Nov 30 '22 16:11 ekacnet

@javierbertoli is there anything blocking here ?

ekacnet avatar Dec 08 '22 04:12 ekacnet