safer_rails_console icon indicating copy to clipboard operation
safer_rails_console copied to clipboard

Does this prevent job queuing?

Open rsanheim opened this issue 3 years ago • 3 comments

Heya cool project! Quick question - I see from the README:

allowing read-only external connections (disables job queueing, non-GET requests, etc.)

However, I'm not seeing anything that would prevent jobs getting enqueued via ActiveJob or Sidekiq or whatever. Am I missing the hook or code that would prevent that from happening?

We currently enforce a sandbox for our prod console via some scripting, but there is nothing preventing someone from accidentally kicking off some model method that enqueues a job that ends up modifying data off in a different process. I know there are various hooks and things that we could use in ActiveJob or Sidekiq, but came here looking to see if there are some nice established patterns to use 😁 .

rsanheim avatar Jun 30 '22 22:06 rsanheim

Apologies @rsanheim but this gem currently only supports sandboxing for Postgres connections. #1 and #22 are tracking generalizing this but we don't have any immediate plans to work on these issues (but contributions are always welcome). I'll fix the README to accurately reflect this.

jturkel avatar Jul 05 '22 13:07 jturkel

README updated in 0cdaeea02de8b2132bba9f5174239b56b3c8e48c.

jturkel avatar Jul 05 '22 14:07 jturkel

#50 handles this

mileszim avatar Dec 02 '22 20:12 mileszim