ember-debug-logger icon indicating copy to clipboard operation
ember-debug-logger copied to clipboard

Published 20 hours ago • verified publisher icon salsify

Allow logging function overrides & add more loggers

Open Ramblurr opened this issue 9 years ago • 3 comments

  • You can now override the logger functions to hook into the instance loggers at runtime.
  • There are also 4 instance loggers available (debug, info, warn, and error). However, only debug and error are injected automatically.

Ramblurr avatar Jun 08 '16 16:06 Ramblurr

Thanks for the PR!

It looks like there are some test failures as the result of this change. I'd also love to see coverage for the expected behavior of the newly-added loggers as well.

dfreeman avatar Jul 12 '16 19:07 dfreeman

Thanks for the feedback, I'll address it and add some fixes to the PR.

Ramblurr avatar Jul 13 '16 08:07 Ramblurr

@Ramblurr Awesome, thanks. Sorry for the long turnaround!

dfreeman avatar Jul 13 '16 13:07 dfreeman