soundcleod icon indicating copy to clipboard operation
soundcleod copied to clipboard

Don't highlight menus with key bindings when typing text into inputs

Open jbergstroem opened this issue 6 years ago • 2 comments

Key bindings (Repost, Like, ..) seems to be highlighted when using search or other input forms. The trigger should probably check for this before firing (seems to be purely cosmetic though, the actual repost or like action doesn't fire).

jbergstroem avatar Aug 22 '18 13:08 jbergstroem

There are measures taken not to trigger those key binding when typing inputs.

Avoiding menu item highlights is s little trickier. The problem is, shortcuts like "L for Like" are implemented on soundcloud.com itself, the shortcut on the menu item is only relevant when the main window does not have keyboard focus (minimized, in background, etc).

The proper solution would disable the menu shortcuts when the main window is focused and re-enable them on blur. I did not investigate whether this is doable with Electron or not, but a pull request to improve is always welcome.

salomvary avatar Aug 27 '18 06:08 salomvary

@salomvary said: I did not investigate whether this is doable with Electron or not, but a pull request to improve is always welcome.

I can't say I'm much better -- I don't know Electron well enough. I just thought it was worth to at least track the issue.

jbergstroem avatar Sep 11 '18 03:09 jbergstroem