imp icon indicating copy to clipboard operation
imp copied to clipboard

Add CI github actions workflow

Open sethaxen opened this issue 4 years ago • 5 comments

As discussed on slack, this PR sets up a github actions CI that builds all of IMP and runs the test suite with code coverage, uploading to codecov.

sethaxen avatar Oct 21 '20 06:10 sethaxen

@benmwebb do you have any idea why ctest doesn't find the tests?

sethaxen avatar Oct 21 '20 07:10 sethaxen

@benmwebb thanks for the changes. Is this now superseded by the ci.yml workflow in the default branch?

sethaxen avatar Jan 05 '21 03:01 sethaxen

Is this now superseded by the ci.yml workflow in the default branch?

No, that in develop is just a stopgap - it does what the old Travis build used to do (just compilation, no tests). (Travis builds stopped working for all our repos because we ran out of credits, so I switched them all to GitHub Actions.) I'd like to run a basic set of tests too, as you're doing here. Something in the nose environment doesn't look quite right yet though (probably because it's trying to run everything in one process, and the tests weren't written with that in mind). I'm gradually replacing nose with pytest in our repos, so I'll probably do that here too rather than mess with nose for too long (unless you want to look at it instead).

benmwebb avatar Jan 05 '21 06:01 benmwebb

Something in the nose environment doesn't look quite right yet though (probably because it's trying to run everything in one process, and the tests weren't written with that in mind). I'm gradually replacing nose with pytest in our repos, so I'll probably do that here too rather than mess with nose for too long (unless you want to look at it instead).

I'll take a stab at it, but no promises.

sethaxen avatar Jan 05 '21 06:01 sethaxen

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@e5c226f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1034   +/-   ##
==========================================
  Coverage           ?   60.64%           
==========================================
  Files              ?       53           
  Lines              ?     3801           
  Branches           ?      416           
==========================================
  Hits               ?     2305           
  Misses             ?     1438           
  Partials           ?       58           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5c226f...8ffe8da. Read the comment docs.

codecov-io avatar Jan 14 '21 11:01 codecov-io