reactive-grpc icon indicating copy to clipboard operation
reactive-grpc copied to clipboard

proto3 file that contains optional fields, but code generator protoc-gen-reactor hasn't been updated to support optional fields in proto3.

Open fer-marino opened this issue 10 months ago • 3 comments

Hi all, so I'm getting this error message which is quite confusing as I consider "optional" a basic functionality. Maybe it is not necessary since a Mono type can also be empty? anyway would be nice if the plugin would handle this transparently.

is a proto3 file that contains optional fields, but code generator protoc-gen-reactor hasn't been updated to support optional fields in proto3.

cheers Fernando

fer-marino avatar Mar 04 '25 12:03 fer-marino

What version of the generator are you using?

rmichela avatar Mar 04 '25 13:03 rmichela

ahhh 1.0.0 as reported in the gradle demo here. With 1.2.4 it works, sorry for the noise.

fer-marino avatar Mar 04 '25 15:03 fer-marino

btw why it uses its own source set?

Image

I think it could use the grpc one, as the generated stub still has a different name. This way we don't have to modify the source set as shown in the example.

fer-marino avatar Mar 04 '25 15:03 fer-marino