p4-fusion icon indicating copy to clipboard operation
p4-fusion copied to clipboard

Audit behaviour when file type changes between non-binary and binary are encountered with `--includeBinaries false`

Open twarit-waikar opened this issue 3 years ago • 0 comments

p4-fusion, when run with the --includeBinaries false arguments, currently disregards binary file changes completely, even if the file was changed from text to a binary file or vice versa.

We need to have a consistent behavior when choosing to ignore binary file changes when the file types are changed in such a manner.

E.g.

Case 1: A file added as text, then change to a binary file in a subsequent CL

p4-fusion will disregard the change and will leave the file state as was in the repo when it was a "text" file.

Case 2: A file added as text, then changed to binary, and then deleted from the depot

p4-fusion will add the file as text initially but not remove it later on since it was intermediately changed to a binary file before it got deleted.

twarit-waikar avatar Jul 21 '22 07:07 twarit-waikar