lwc

lwc copied to clipboard

refactor(template-compiler): move implicit stylesheet import and style token to template compiler

1

## Details Fixes #3931 This will be a breaking change, the `compile` API now requires the file name, which is used to determine the css imports. I've also expanded the...

jmsjtu

Switch from Jest to Vitest

1

Despite the existence of [`lwc-test`](https://github.com/salesforce/lwc-test) and its various `@lwc/jest-*` packages, this repo itself does not require Jest. So we can switch to another test runner if we want. ...And I...

nolanlawson

fix: implement stylesheet registration and disallow arbitrary functions

1

#3443 * fix: implement stylesheet registration and disallow arbitrary functions * feat: log as error and use reporting API * fix: move to dev-only warning, address PR comments * fix:...

jye-sf

Currently our generated code for templates looks like this: ```js tmpl.stylesheets = []; if (_implicitStylesheets) { tmpl.stylesheets.push.apply(tmpl.stylesheets, _implicitStylesheets); } if (_implicitScopedStylesheets) { tmpl.stylesheets.push.apply(tmpl.stylesheets, _implicitScopedStylesheets); } ``` This is a lot...

nolanlawson

Use `node:` protocol for all builtin imports (`fs`, `path`, etc.)

1

We should use an ESLint plugin like [`prefer-node-protocol`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md) and ensure we're always doing this: ```js import fs from 'node:fs' ``` instead of this: ```js import fs from 'fs' ``` The...

nolanlawson

Normalize whitespace for `style` and `class` attributes (breaking change)

2

For HTML templates containing static `style`/`class` attributes such as this: ```html ``` ... we are inconsistent about how this is actually serialized to the DOM. For static-optimized nodes, the attributes...

nolanlawson

Adding multiple animations to an element breaks compiler's keyframe name replacement.

2

### Description On a LWR Site, I am creating a keyframe in a lwc and the code is adding the component name to the keyframe's name. If I add more...

augustoZaelot

## Details ## Does this pull request introduce a breaking change? - 😮‍💨 No, it does not introduce a breaking change. - 💔 Yes, it does introduce a breaking change....

ekashida

If you set a breakpoint in this function: https://github.com/salesforce/lwc/blob/3665f31e94ee8b990036c7caaa4be4d4496d77ca/packages/%40lwc/engine-core/src/framework/modules/computed-class-attr.ts#L23 and run the Karma tests, you'll find that `className` can be a string, null, undefined, a number... Lots of things. But...

nolanlawson

For a template like this: ```html one two three ``` ... we currently compile this into: ```js const $fragment1 = parseFragment`one`; const $fragment2 = parseFragment`two`; const $fragment3 = parseFragment`three`; function...

nolanlawson