lwc icon indicating copy to clipboard operation
lwc copied to clipboard

refactor: version mismatch warning on patch version difference

Open SourabhMulay opened this issue 1 year ago • 2 comments

Details

Version mismatch warning should warn on patch version differences so if LWC compiler version differs from the engine version, it warns.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

SourabhMulay avatar May 21 '24 05:05 SourabhMulay

Hi @wjhsf , I have done with the requested changes that you have suggested, Can you please review once.

SourabhMulay avatar May 29 '24 12:05 SourabhMulay

Looks like there's issues with the CLA bot - please connect your GitHub account to your Salesforce email so that CLA check is no longer necessary.

wjhsf avatar May 30 '24 14:05 wjhsf

Thanks for the contribution! It looks like @SourabhMulay is an internal user so signing the CLA is not required. However, we need to confirm this.

salesforce-cla[bot] avatar Jun 11 '24 18:06 salesforce-cla[bot]

Hi @SourabhMulay could you please sign the CLA as mentioned above? Thanks! 🙇

nolanlawson avatar Jun 13 '24 19:06 nolanlawson

Hi @SourabhMulay could you please sign the CLA as mentioned above? Thanks! 🙇

Already signed, maybe there is an issue with the cla bot. But i'll try to change the commit email once.

SourabhMulay avatar Jun 14 '24 09:06 SourabhMulay

/nucleus test

nolanlawson avatar Jun 14 '24 16:06 nolanlawson

/nucleus test

nolanlawson avatar Jun 14 '24 20:06 nolanlawson

/nucleus ignore --reason 'flapper unrelated to this PR'

nolanlawson avatar Jun 14 '24 21:06 nolanlawson

Thank you! Thank you!! @nolanlawson.

SourabhMulay avatar Jun 15 '24 13:06 SourabhMulay