lwc icon indicating copy to clipboard operation
lwc copied to clipboard

Add CI check that all TODO are addressed by a PR

Open wjhsf opened this issue 1 year ago • 2 comments

If a PR fixes an issue, then it would be nice if we could somehow catch all TODOs related to the fixed ticket, so that all the relevant changes can be made (or filed as a separate follow up).

As an example, #3988 fixed #3366, but there was follow up work that was not addressed: https://github.com/salesforce/lwc/blob/ac6514035a474e6bae90bb599f9a6508002cabf4/packages/%40lwc/engine-core/src/typings/weakref.d.ts#L7-L8

wjhsf avatar Feb 12 '24 20:02 wjhsf

hi everyone, wanted to contribute to this issue, any help on how to get started with this?

le-incroyable1-dev avatar Feb 25 '24 11:02 le-incroyable1-dev

You could probably use grep to parse the codebase for TODO [#0000] to get the list of issue IDs. I don't know if GitHub Actions has any built-in mechanism to look up issues, but the GitHub CLI does, so you may be able to use that.

wjhsf avatar Feb 27 '24 16:02 wjhsf