lwc-test icon indicating copy to clipboard operation
lwc-test copied to clipboard
verified publisher icon salesforce

chore: transform `import.meta.env.SSR` to `false` within component code

Open divmain opened this issue 2 years ago • 2 comments

The import.meta.env.SSR flag is used in component code where the component author needs to vary behavior depending on the execution environment. In production, import.meta.env.SSR will be either true (if the component is being server-rendered) or false (if the component is rendering in the browser).

We do not intend for Jest to be used to test SSR & component hydration. For that reason, import.meta.env.SSR should always evaluate to false in Jest tests. This PR makes that change.

divmain avatar Sep 20 '23 00:09 divmain

We do not intend for Jest to be used to test SSR & component hydration.

We do have SSR testing capabilities.

nolanlawson avatar Sep 20 '23 15:09 nolanlawson

@divmain Just saw that we were both adding solutions for the very same issue (PR #217) ;) I can only say that the assumption of your PR isn't really true. We already have repositories that are set up to both test SSR and CSR behavior via Jest. That's why we should make sure that this is taken into account.

seckardt avatar Nov 09 '23 11:11 seckardt