design-system-react icon indicating copy to clipboard operation
design-system-react copied to clipboard

Published 20 hours ago • verified publisher icon salesforce

Drop IE11 support and CommonJS?

Open jimmydief opened this issue 1 year ago • 0 comments

IE11 was officially retired by Microsoft in June 2022. Would it be possible to update the list of supported targets here?

https://github.com/salesforce/design-system-react/blob/ccbca0673b00a79a96745b590974c9c262db2e43/babel.config.js#L7-L8

Similarly, the library package on npm includes three different unbundled versions of each component:

  1. Source code in /components
  2. Compiled ES modules in /module/components
  3. Compiled CommonJS modules in /lib/components

There also seem to be several bundled versions of the entire library:

  1. design-system-react-components.js
  2. design-system-react-components.min.js
  3. design-system-react.js
  4. design-system-react.min.js

While decreasing the size of the npm package would certainly be nice, the main reason that it would be nice to consolidate on ESM would be to avoid accidentally duplicating versions of these components in apps which still use a mix of ESM and CommonJS. This is a pretty common footgun which results in increased bundle size as well as bugs when "stateful" things like context or settings are duplicated.

jimmydief avatar Mar 16 '23 23:03 jimmydief