design-system-react icon indicating copy to clipboard operation
design-system-react copied to clipboard

Combobox findDOMNode is deprecated in StrictMode

Open dlferro opened this issue 2 years ago • 2 comments

I've run into this warning using the combobox with React 17. It appears that it was tackled previously with popovers. @interactivellama is the gist of this issue just replacing it with components reference? I'm assuming in this instance it's a utility or sub component of comobox.

dlferro avatar Mar 03 '22 17:03 dlferro

Also running into this

pmartin35 avatar Jun 06 '22 13:06 pmartin35

This is likely an issue found in the https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigate.js and https://github.com/salesforce/design-system-react/blob/master/utilities/keyboard-navigable-dialog.js which calls findDOMNode to check for event target.

yes, it likely can be updated to compare refs.

interactivellama avatar Jun 07 '22 18:06 interactivellama