design-system-react icon indicating copy to clipboard operation
design-system-react copied to clipboard

'No matches found' tooltip persists even after inputting item in combobox

Open sktguha opened this issue 4 years ago • 9 comments

In combobox, the 'no matches found' tooltip is not cleared after the user has inputted the input after pressing enter.

Steps to reproduce:

Go to https://react.lightningdesignsystem.com/components/comboboxes/ then go to examples: 'Inline Single Selection' and replace the code in code editor with the below code

https://gist.github.com/sktguha/55f1f78d0b29375ea52ff4436384bee5

if you enter any input and press enter, the tooltip 'No matches found' still persists, as shown in the image below. image

sktguha avatar Aug 17 '20 15:08 sktguha

Thanks for opening your first issue! :wave: If you have found this library helpful, please star it. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread.

welcome[bot] avatar Aug 17 '20 15:08 welcome[bot]

hi, any update? Currently, I am working around it by calling .focus on the next focussable element, which triggers the onblur thus hiding the tooltip, but it will be good if there is a permanent solution for this.

sktguha avatar Aug 21 '20 06:08 sktguha

Thanks for opening the issue! Unfortunately, there is no team dedicated to fixing issues in this project, so it may take some time to get to get around to this. If you already have an idea for how to fix it, feel free to open a PR with the fix. Thanks again!

garygong avatar Aug 25 '20 23:08 garygong

Hi @garygong thanks for the response. so basically I have solved it currently by

Currently, I am working around it by calling .focus on the next focussable element, which triggers the onblur thus hiding the tooltip,

sktguha avatar Aug 26 '20 17:08 sktguha

Unfortunately, there is no team dedicated to fixing issues in this project

It is an abandoned project ?

rlodina avatar Sep 13 '20 09:09 rlodina

I wouldn't say it's abandoned. We still review PRs and create new releases, but rely on others to submit bug fixes.

garygong avatar Sep 14 '20 18:09 garygong

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

stale[bot] avatar Dec 19 '20 08:12 stale[bot]

The behaviour that @sktguha mentioned is due to the check for menuOptions.length in combobox. Here is the snippet

{menuOptions.length ? (
		menuOptions
	) : (
		<li
			className="slds-listbox__item slds-listbox__status"
			role="status"
			aria-live="polite"
		>
			<span className="slds-m-left_x-large slds-p-vertical_medium">
				{props.labels.noOptionsFound}
			</span>
		</li>
	)}

Is there a use case where the options list is empty? If the list is not empty, entering giberish leaves the entire option list showing indicating that there is no match. This seems to be a correct behaviour as the user is expected to select from one of the options. Right?

lawteo avatar Sep 07 '21 07:09 lawteo

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

stale[bot] avatar Apr 18 '22 19:04 stale[bot]