design-system-react icon indicating copy to clipboard operation
design-system-react copied to clipboard

Published 20 hours ago • verified publisher icon salesforce

Timepickers: Update to use Combobox

Open arodenbeck opened this issue 6 years ago • 3 comments

Currently timepicker functions like a combobox, but screen readers only understand it to be an input.

arodenbeck avatar Jan 23 '18 20:01 arodenbeck

@interactivellama if no one is working on this, I can do it.

shleewhite avatar Nov 21 '19 23:11 shleewhite

No one is. Sounds great! It was started back in this issue. https://github.com/salesforce/design-system-react/pull/1430

The best thing may be to start from scratch and write a new component and just add some variants to Combobox. I'm not sure what that new component name would be though.

What would you like to propose?

interactivellama avatar Nov 22 '19 00:11 interactivellama

I agree about just using the Combobox component... I'd be hesitant to change the name since it's called Timepicker in SLDS. Can I rewrite the component and keep the same name?

edit: going to call it TimepickerCombobox

shleewhite avatar Nov 22 '19 00:11 shleewhite