FuelSDK-Python icon indicating copy to clipboard operation
FuelSDK-Python copied to clipboard
verified publisher icon salesforce-marketingcloud

Remove suds-jurko

Open seahawks8 opened this issue 4 years ago • 21 comments

  • Removed dependency on suds-jurko due to setuptools>=58.0.0 not supporting 2to3, pointed to suds-community
  • Removed wsgiref because it is part of the standard lib
  • Removed distribute as it is part of setuptools.

seahawks8 avatar Nov 13 '21 20:11 seahawks8

👍🏻

amoldabade7 avatar Dec 01 '21 10:12 amoldabade7

+1

bobglobe avatar Dec 03 '21 09:12 bobglobe

Hello @manivinesh @sfdrogojan @rhrituc

Can you please review and release this change so that it can unblock the dependencies?

Thanks, Amol

amoldabade7 avatar Dec 06 '21 06:12 amoldabade7

it'd be awesome if this could be merged

brno32 avatar Dec 21 '21 20:12 brno32

@BrunoJolivi can you merge?

seahawks8 avatar Dec 22 '21 15:12 seahawks8

Hi @BrunoJolivi, polite bump. I'd love to see this merged.

mcohoon avatar Feb 01 '22 19:02 mcohoon

^^bump^^

seahawks8 avatar Feb 03 '22 15:02 seahawks8

Linking Issue 135 if this helps get it attention. @smashew any update on this would be much appreciated.

mcohoon avatar Feb 03 '22 17:02 mcohoon

^^bump^^

seahawks8 avatar Feb 18 '22 05:02 seahawks8

+1 it would be great to get this merged

bogdanp05 avatar Mar 15 '22 15:03 bogdanp05

+1

dillonkelley avatar Apr 07 '22 15:04 dillonkelley

if this gets merged, an angel will get its wings

brno32 avatar Apr 07 '22 15:04 brno32

@svc-scm I see that you were able to merge a PR in October, It would be great if you would be able to merge this PR.

mcohoon avatar Apr 07 '22 15:04 mcohoon

what do you think, if this does not get merged, should I fork and push my own to maintain?

seahawks8 avatar Apr 14 '22 06:04 seahawks8

@pceric or @BrunoJolivi can you give us an update on this? We'd love to see this merged 🥺 🙏

pietercusters avatar Apr 20 '22 15:04 pietercusters

I'm gonna lose my job if this doesn't get merged soon. Please help!

brno32 avatar Apr 28 '22 16:04 brno32

@brno32 you can fork this repository and merge it and give it a new version number, and then build your service off of your own forked version of the library. I would also suggest to everyone following this thread to please contact your SFMC sales rep and ask them to escalate this issue to someone who may have the authority to merge this PR.

mcohoon avatar Apr 28 '22 19:04 mcohoon

@mcohoon yeah we've got our own fork as a work-around for now. Thanks for the suggestion! I've followed up with some colleagues on my end to get this escalated.

brno32 avatar Apr 28 '22 19:04 brno32

If you don't want to fork you can simply

pip install -r requirements.txt --no-deps

with these requirements:

PyJWT>=1.5.3
requests>=2.18.4
suds-community>=0.7
Salesforce-FuelSDK==1.3.0

pietercusters avatar May 02 '22 08:05 pietercusters

looks like someone (me) forked this project, fixed it, and published a new version. https://pypi.org/project/Salesforce-FuelSDK-Sans/

pip install Salesforce-FuelSDK-Sans

seahawks8 avatar Jun 20 '22 16:06 seahawks8

Hello, Could someone please merge this pull request?

Heroku will be discontinuing support for its 18 stacks starting from May 1st, and it is required for the apps to migrate to the latest stack 22. However, the latest stack uses the latest version of setuptools (67~), and due to this, the SDK is not compatible with stack 22.

It is important that we address this issue as soon as possible. thanks!

subodhjena avatar Apr 01 '23 07:04 subodhjena