FuelSDK-Python
FuelSDK-Python copied to clipboard
[Enhancement] Improve error handling in ET_Client instantiation
Is your feature request related to a problem? Please describe
- When configuring the ET_Client, loading the WSDL and refreshing the token, the current code only raise base
Exceptions, which are not ideal to handle for developers - Potential HTTP errors coming from
requestsare not properly handled - In the ET_Client params,
applicationType, if notNoneor blank, can be anything
I already created a PR to improve those 3 points: #123
Solutions
- Create a base class for exceptions raised by the ET_Client, and subclasses for the different scenarios (configuration, loading WSDL, token refresh)
- Use
Response.raise_for_statusto handle HTTP error responses coming fromrequests - Handle that case properly, and raise a new
ConfigurationExceptionin case of unallowed value
I also added tests for these error scenarios, in a specific file, FuelSDK/test_ET_Client_errors.py