FuelSDK-PHP icon indicating copy to clipboard operation
FuelSDK-PHP copied to clipboard

option to read from config. Fix php 7 issues

Open rodruiz opened this issue 4 years ago • 5 comments

Fixes:

  • #144
  • #159

To read the config file from a custom path:

$myclient = new ET_Client(true, false, null, true, '/path/to/config.php');

To ignore config file:

$params = array(...);
$myclient = new ET_Client(true, false, $params, false);

I can submit another PR to optimize and remove duplicate code from ET_Client constructor. Merging $params with $config should do the trick.

rodruiz avatar Feb 04 '21 23:02 rodruiz

Why this fix wasn't merged yet?

PWalkow avatar Apr 12 '21 15:04 PWalkow

is there another plan for this, why is still not merged?

dsepulveda-pr avatar Oct 27 '21 21:10 dsepulveda-pr

@PWalkow and @dsepulveda-pr you can use my branch doing the following:

1- Add the following to your composer.json file

    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/rodruiz/FuelSDK-PHP.git"
        }
    ]

2- Replace:

{
    "require": {
        "salesforce-mc/fuel-sdk-php": "1.4.0"
    }
}

with:

{
    "require": {
        "salesforce-mc/fuel-sdk-php": "dev-master"
    }
}

rodruiz avatar Oct 27 '21 21:10 rodruiz

@manivinesh Looks like you have approved previous PRs. Would you mind reviewing this one? This sdk is unusable in PHP 7.4 at the moment.

JeremyDunn avatar Nov 19 '21 16:11 JeremyDunn

can someone please review and merge this PR

boxyashish avatar Dec 03 '21 18:12 boxyashish