FuelSDK-PHP icon indicating copy to clipboard operation
FuelSDK-PHP copied to clipboard

Fix PHP 7.4 bug #159

Open mstralka opened this issue 4 years ago • 8 comments

Sorry for the reformatting this was really only a few changes to fix #159 by changing several instances of:

if ($this->tenantTokens[$tenantKey] == null) {

to

if (!isset($this->tenantTokens[$tenantKey]) || $this->tenantTokens[$tenantKey] == null) {

and initializing $this->tenantTokens in the constructor instead of a local variable.

mstralka avatar Jun 02 '20 20:06 mstralka

Can this be rebased on the latest instead of the 1.2.2 version?

Also, this change could be added, since it's for the same reason. It's confirmed by the existing CacheServiceTest::testWhenNewInstanceIsCreatedGetReturnsNull().

iisisrael avatar Aug 21 '20 16:08 iisisrael

Actually this change as well.

iisisrael avatar Aug 27 '20 16:08 iisisrael

Hi, what is missing to merge this? Could I help with something to get this merged?

rgarnica avatar Sep 04 '20 21:09 rgarnica

I have the same issue. Changes looks well :+1:

ping86 avatar Sep 29 '20 07:09 ping86

Any news on getting this merged?

stef686 avatar Jan 08 '21 14:01 stef686

Yes, I would certainly benefit from this fix.

simonmc3 avatar Aug 24 '21 14:08 simonmc3

@manivinesh @sfdrogojan could you guys help us with that?

faelgabriel avatar Aug 24 '21 16:08 faelgabriel

can someone please merge this PR to master branch, as we need this fix asap

boxyashish avatar Dec 03 '21 18:12 boxyashish