FuelSDK-PHP
FuelSDK-PHP copied to clipboard
Fix PHP 7.4 bug #159
Sorry for the reformatting this was really only a few changes to fix #159 by changing several instances of:
if ($this->tenantTokens[$tenantKey] == null) {
to
if (!isset($this->tenantTokens[$tenantKey]) || $this->tenantTokens[$tenantKey] == null) {
and initializing $this->tenantTokens in the constructor instead of a local variable.
Can this be rebased on the latest instead of the 1.2.2 version?
Also, this change could be added, since it's for the same reason. It's confirmed by the existing CacheServiceTest::testWhenNewInstanceIsCreatedGetReturnsNull()
.
Actually this change as well.
Hi, what is missing to merge this? Could I help with something to get this merged?
I have the same issue. Changes looks well :+1:
Any news on getting this merged?
Yes, I would certainly benefit from this fix.
@manivinesh @sfdrogojan could you guys help us with that?
can someone please merge this PR to master branch, as we need this fix asap