Fix #6111 - Layout Panel title cannot be changed or edited

[JackBuchanan]

Merge mod string arrays for lang and override files before returning because override files are written to but not read from in module builder

Description

When building modstrings for module builder merge in the _override lang file before returning modstrings

Motivation and Context

Fixes issue with users being unable to rename panels in the module builder

How To Test This

Create a module in module builder, edit the detailview layout and try to change the panels labels, see issue #6111

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[johnM2401]

Hey @JackBuchanan !

I've had a try at testing this PR, but I appear to be getting the same results before and after applying the PR.

See attached gif:

The "Default" Panel can still not be edited, and the editing pencil changes on-save for the other panels. (As shown in the original issue's Screenshots)

I've tried rebuilding the themes, Clearing cache and R&R, but no changes i'm afraid.

Have I perhaps missed something necessary? Or misunderstood the intention of the fix?

Thanks! John

[serhiisamko091184]

Hello, @JackBuchanan

The PR has been marked as stale because there has been no recent activity. It will be closed if no further activity occurs. Thanks for your contributions.

Regards, Serhii