Fix #9745 - Fix email signatures being replaced

[JackBuchanan]

Remove code that replaces email signatures

Description

Fixes Issue 1 - Email signatures are not added when replying to email if an email signature has been added by SuiteCRM already. Fixes Issue 2 - Existing email signatures in email thread are replaced on load by SuiteCRM if the email signature has been updated in the user profile, this will cause issues if other applications use the HTML class "email-signature" for their signature as SuiteCRM will replace it with the user who is composing the email. Same issue if two users in SuiteCRM are in an email thread together, the person composing the email will have their email signature replace the other users signature in the email thread. Functionality Change: Previously if using the system mailbox the email signature was hard codded to always append email signature(function: getFillDataAddressArray in modules/Emails/EmailsDataAddressCollector.php). Now the append/prepend preference thats set in the user profile is applied when using the system mailbox.

Motivation and Context

If email signature is already added in the thread then a new signature will not be added and will be replaced by the users current signature.

How To Test This

1. Set-up outbound email
2. Add an email signature in the user profile
3. Send email to inbound mailbox
4. Update email signature to be different from what was originally set
5. Check email from within SuiteCRM and "reply to"
6. See that email signature is added and not signatures are replaced

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[clemente-raposo]

Hi @JackBuchanan, thank you for your PR. There were a lot of changes to emails in 7.13.x. And they also touch some of these files. Can you check if your PR still works in 7.13.x please? Maybe also a good idea to point this PR to hotfix-7.13.x

[serhiisamko091184]

Hello, @JackBuchanan

The PR has been marked as stale because there has been no recent activity. It will be closed if no further activity occurs. Thanks for your contributions.

Regards, Serhii