theme SuiteP: Use LatoLatin instead of Lato

[BKPepe]

Description

Some characters used in Czech like ěčř or Romanian language are not present in Lato font and they are rendered in Arial, which does not look good.

There exists LatoLatin [1] from the same author, which includes glyphs for European Latin-based languages.

[1] https://www.latofonts.com/lato-free-fonts/

Motivation and Context

Before:

After:

Fixes: #7255

How To Test This

If you are using CloudFlare then you need to purge cache and if it does not work then try to disable DNS proxy. But that's not all. You need to enable Developer mode in SuiteCRM, which worked in the end for me according to SuiteCRM's Discourse forum: https://community.suitecrm.com/t/editing-css-how-to-refresh-cache/33675/

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[codecov-io]

Codecov Report

Merging #8962 (10be89f) into master (d57e913) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #8962   +/-   ##
=========================================
  Coverage     11.45%   11.45%           
  Complexity    41656    41656           
=========================================
  Files          3292     3292           
  Lines        245905   245905           
=========================================
  Hits          28157    28157           
  Misses       217748   217748           

[BKPepe]

It would worth a shot to try the latest version of nomanize.css, which is using correct indentation and it could bring more improvements, but this is not part of this pull request and someone could take a look at it later.

[pgorod]

Initially I thought that LatoLatin was a larger font file, with more characters in it, but from what I just read online, it's the opposite, it's supposed to be a subset of Lato. I find this confusing, if it is a subset, then why does it bring in characters that Lato failed to display?

I wonder if moving to LatoLatin creates other kinds of problems, namely with Cyrillic (@likhobory can you please check?)

Another thing that might make sense is to list both: 'Lato', Lato, LatoLatin, ...

[likhobory]

It looks good.

[BKPepe]

I find this confusing, if it is a subset, then why does it bring in characters that Lato failed to display?

This could be caused that Google Fonts offers v1, which didn't contain Latin chars, but v2 contains them, but while looking at the size of each font it is incredibly large (almost two times bigger for each font) and someone (I do not) could be using SuiteCRM on phone and while using broadband connection every byte counts. That's why I jumped on LatoLatin, which was almost equal to font size, which is in the repository.

This is preview of Latin fonts, which I downloaded for website from https://www.latofonts.com/lato-free-fonts/, so the fonts are there.

Another thing that might make sense is to list both: 'Lato', Lato, LatoLatin, ...

As said above, potentially we can do it, but you don't want to ship two versions of fonts and each variant of it (bold, italic, and such). Still, I wonder, why we can not use some font, which is already presented in almost any system.

[chris001]

Is master the right branch? Or should it be to hotfix?

[BKPepe]

You tell me, since there is a conflict, I need to solve the merge conflict and rebase it.

Dne po 19. 2. 2024 18:14 uživatel Chris Coleman @.***> napsal:

Is master the right branch? Or should it be to hotfix?

— Reply to this email directly, view it on GitHub https://github.com/salesagility/SuiteCRM/pull/8962#issuecomment-1952905622, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7IDVCZGINGIX2Z7WLANHDYUOB7RAVCNFSM4TVSQ6L2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGI4TANJWGIZA . You are receiving this because you authored the thread.Message ID: @.***>

[chris001]

@BKPepe The default branch for pull requests is hotfix... if you could rebase to hotfix, they should accept this easier.