Bug Fixes & Minor Performance Enhancements

[grahambrown11]

Description

From using SuiteCRM for the last 3 years we've stumbled over a few issues which we've resolved in our own code base, we are now contributing them back to the main project.

Motivation and Context

These changes address bugs and some performance enhancements from the many years of running SuiteCRM using modules built with Module Builder that have complex relations. We are now trying to upgrade from Suite 7.6 to 7.11 and in this exercise we thought to rather submit these changes to the main project so we don't have to continually merge the changes on each upgrade.

I've tried to make each commit message descriptive so at least there is some context as to why the change... One of the most significant changes is to get Module Builder and Studio to stop adding a comment with the datetime everytime we rebuild or deploy as those would cause a change in git, but the only change was date and time in a comment.

How To Test This

Unfortunately we've lost some context with most of the issues as they've come up from users using the system over the last 3 years, so we only have the fixes not why they occurred or how to reproduce the issues

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[grahambrown11]

Sorry I see my changes are failing the unit tests, I'll rather try get the test suite running locally now and fix them

[Mac-Rae]

@grahambrown11 Looks like the merge of hotfix-7.10.x into your branch failed Travis and thereafter everything else failed. Could be an issue with that commit altho I'm not sure. I'm going to pull your branch down, merge in hotfix-7.10.x and run it locally.

[gunnicom]

"One of the most significant changes is to get Module Builder and Studio to stop adding a comment with the datetime everytime we rebuild or deploy" God send you :D I also have my production in git, and after each QRR i get annoyed by all these No-Changes.

[grahambrown11]

I've corrected the tests, the one change we made was to change modules based on person to return a dash for full name when missing the first and last name, this is due to our system using the bean directly and missing the UI validation that first or last name are required. This causes an issue in the UI where the browser does not show a link so you can view/edit that record...

[codecov-io]

Codecov Report

Merging #8317 into hotfix-7.10.x will increase coverage by <.01%. The diff coverage is 23.11%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #8317      +/-   ##
=================================================
+ Coverage          10.59%   10.59%   +<.01%     
=================================================
  Files               3229     3229              
  Lines             240066   240169     +103     
=================================================
+ Hits               25432    25454      +22     
- Misses            214634   214715      +81

[samus-aran]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- include/MySugar/MySugar.php  2
- modules/Trackers/monitor/tracker_monitor.php  1
         

See the complete overview on Codacy

[SuiteBot]

All committers have signed the CLA.

[codecov-commenter]

Codecov Report

Merging #8317 into hotfix-7.10.x will decrease coverage by 0.00%. The diff coverage is 24.24%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #8317      +/-   ##
=================================================
- Coverage          10.69%   10.69%   -0.01%     
=================================================
  Files               3230     3230              
  Lines             241063   241076      +13     
=================================================
- Hits               25792    25791       -1     
- Misses            215271   215285      +14