Scheduled Reports: Edit View: Various smaller fixes

[lazka]

Description

Various smaller fixes for the "Scheduled Reports" edit view page, each in a separate commit.

Broken things:

• Removing emails didn't work
• It defaulted to the advanced cron input instead of the basic one
• The cron input selects didn't get translated to other languages
• Showing it led to PHP errors in the log because of non-existing leftover fields

Layout before:

Layout after:

Month day select before/after (German):

Week day select before/after (German):

Motivation and Context

I'd like my users to create scheduled reports themselves and so I'm trying to make the user experience better (Also removing emails didn't actually work..)

How To Test This

• Create a new Scheduled Report record
• The edit view should show the basic cron input with translated strings in one row
• Add an email address and save.
• Re-edit the record and try to remove the email address again, it should work.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[Mac-Rae]

Assessed :+1:

[lazka]

Thanks for the hints, I'll look into it.

[codecov-io]

Codecov Report

Merging #7519 into hotfix-7.10.x will increase coverage by <.01%. The diff coverage is 12.5%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7519      +/-   ##
=================================================
+ Coverage          10.59%   10.59%   +<.01%     
=================================================
  Files               3227     3227              
  Lines             240029   240049      +20     
=================================================
+ Hits               25434    25437       +3     
- Misses            214595   214612      +17

[lazka]

I've moved the formatting into SugarFieldCronSchedule. If someone wants to reuse it it can easily be moved to a more central place now.

This should be ready.

[samus-aran]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 4
           

Complexity increasing per file
==============================
- include/SugarFields/Fields/CronSchedule/SugarFieldCronSchedule.js  1
         

See the complete overview on Codacy

[SuiteBot]

All committers have signed the CLA.

[lazka]

Some of this has been fixed now in #9635 and #9637. I can rebase if wanted and drop the two overlapping commits.