SuiteCRM icon indicating copy to clipboard operation
SuiteCRM copied to clipboard

*WIP Move Jstree to composer

Open Dillon-Brown opened this issue 5 years ago • 6 comments

Description

Removes jstree from include and moves it to composer.

How To Test This

  1. Check that the JS tree in the email module works as expected.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [x] My code follows the code style of this project found here.
  • [ ] My change requires a change to the documentation.
  • [x] I have read the How to Contribute guidelines.

Dillon-Brown avatar May 17 '19 08:05 Dillon-Brown

Codecov Report

Merging #7296 into develop will increase coverage by <.01%. The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop    #7296      +/-   ##
=============================================
+ Coverage      10.84%   10.84%   +<.01%     
  Complexity     42086    42086              
=============================================
  Files           3375     3375              
  Lines         247880   247880              
=============================================
+ Hits           26888    26889       +1     
+ Misses        220992   220991       -1

codecov-io avatar May 17 '19 11:05 codecov-io

Assessed :+1:

cameronblaikie avatar Jun 07 '19 15:06 cameronblaikie

Needs a rebase :)

connorshea avatar Jul 18 '19 18:07 connorshea

Looks like flaky tests, we should really merge hotfix into develop so develop PRs won't suffer from these as much anymore.

connorshea avatar Jul 31 '19 20:07 connorshea

@connorshea Agreed. It looks like there are only 81 files conflicting so it shouldn't be too difficult. I'll look at putting up a PR.

Dillon-Brown avatar Aug 01 '19 08:08 Dillon-Brown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: Dillon-Brown
:white_check_mark: isleshocky77
:white_check_mark: lazka
:white_check_mark: samus-aran
:white_check_mark: cameronblaikie
:x: code-ph0y
You have signed the CLA already but the status is still pending? Let us recheck it.

SuiteBot avatar Aug 27 '20 13:08 SuiteBot