SuiteCRM icon indicating copy to clipboard operation
SuiteCRM copied to clipboard

Adding show_completed argument to iCall

Open sanchezfauste opened this issue 7 years ago • 5 comments

Adding show_completed argument to iCall to be able to hide the completed Meetings, Calls and Tasks.

Description

Adding a parameter to specify if the completed tasks, meetings and calls have to be present to the returned icall. By default this parameter is true.

Motivation and Context

We think that showing the completed tasks in the calendar is not so useful when there are a lot of tasks. It would be very useful if you can choose if you want to see the completed tasks or not.

How To Test This

Obtain iCall without completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=false

Obtain iCall including completed tasks, meetings and calls: https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true&show_completed=true

or simply:

https://crm.example.com/ical_server.php?type=ics&key=XXX&email=YYY&show_tasks_as_events=true

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [x] My code follows the code style of this project found here.
  • [x] My change requires a change to the documentation.
  • [x] I have read the How to Contribute guidelines.

sanchezfauste avatar Jul 17 '17 16:07 sanchezfauste

Hi @sanchezfauste You still need to sign the Clahub Contributor License Agreement.

Dillon-Brown avatar Jul 17 '17 17:07 Dillon-Brown

Thank you @Dillon-Brown, I have signed the Contributor License.

sanchezfauste avatar Jul 17 '17 18:07 sanchezfauste

Please resolve the conflicts on this pull request bringing it up to date.

Mac-Rae avatar Aug 05 '19 13:08 Mac-Rae

Please resolve the conflicts on this pull request bringing it up to date.

Done.

sanchezfauste avatar Aug 05 '19 13:08 sanchezfauste

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

:white_check_mark: Dillon-Brown
:white_check_mark: isleshocky77
:white_check_mark: samus-aran
:white_check_mark: lazka
:white_check_mark: sanchezfauste
:white_check_mark: cameronblaikie
:x: code-ph0y
You have signed the CLA already but the status is still pending? Let us recheck it.

SuiteBot avatar Aug 27 '20 13:08 SuiteBot