Fix #325 - Required validation

[yunusyerli1]

Description

Just changed order of below lines: #325 data.field.definition.required = required; data.field.formControl.setValidators(validators); data.field.formControl.updateValueAndValidity({onlySelf: true, emitEvent: true}); record.formGroup.updateValueAndValidity({onlySelf: true, emitEvent: true});

Motivation and Context

How To Test This

Choose Service as Missed Collection in Case Module. Select Yes in Further Action Required field. Fill Outcome field. Click Save and Continue button. Check Outcome field again.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• [x] My code follows the code style of this project found here.
• [ ] My change requires a change to the documentation.
• [x] I have read the How to Contribute guidelines.

[clemente-raposo]

Hi @yunusyerli1, I think has already been fixed. Do you confirm?

[yunusyerli1]

Hi @yunusyerli1, I think has already been fixed. Do you confirm?

Yes, ı do confirm but there are repetitive lines.

[johnM2401]

Hey @yunusyerli1 !

It looks like your "How to Test this" sections contains instructions that refer to an already customized instance, so I'm not 100% sure how to confirm the initial issue or proposed fix.

Is this just validation for Dynamic Dropdowns, or dependant fields?

Could you add some more generic replication/testing steps, that would be more for a vanilla Suite8 environment? (or a brief description on what is required to test)

Thanks!

[yunusyerli1]

Hey @yunusyerli1 !

It looks like your "How to Test this" sections contains instructions that refer to an already customized instance, so I'm not 100% sure how to confirm the initial issue or proposed fix.

Is this just validation for Dynamic Dropdowns, or dependant fields?

Could you add some more generic replication/testing steps, that would be more for a vanilla Suite8 environment? (or a brief description on what is required to test)

Thanks!

This is for dynamic dependants of a dropdown validation. It was customized instance with new module with some different services. So, honestly, ı cant say how to test this. Regards.

[johnM2401]

Hey! Thanks for getting back

hmmmm, in that case, do you see this having any possible issues worth testing for, @clemente-raposo ? It seems low impact so would be happy to approve as-is, if there's no concerns.

Thanks!