storefront icon indicating copy to clipboard operation
storefront copied to clipboard

Decide the future of `material-ui`

Open typeofweb opened this issue 1 year ago • 6 comments

Currently we're using material-ui packages in packages/checkout-storefront. There are a few concerns:

  • We're on version 4 which is not longer developed
  • material-ui 4 forces us to use getInitialProps in Next.js which results in poor performance and limits our abilities to optimize

We should either upgrade to material-ui 5 (renamed to @mui/material) or drop it completely and replace with something else (what?).

typeofweb avatar Jul 20 '22 00:07 typeofweb

macaw-ui uses material-ui 4, this is why we have version 4 here. I guess we should update it in macaw-ui first, knowing that it is also used in the dashboard.

orzechdev avatar Jul 20 '22 07:07 orzechdev

@orzechdev I'm not sure but afaik macaw doesn't have much in common looks wise with storefront designs

bmigirl avatar Jul 20 '22 09:07 bmigirl

@bmigirl Yes, storefront doesn't need macaw at all, but I'm saying about dashboard app, which now with storefront exists in the single project.

orzechdev avatar Jul 20 '22 09:07 orzechdev

We should at least remove it from checkout 😅 - there's for example one type that's for some weird reason also used in SPA: https://github.com/saleor/saleor-checkout/blob/main/packages/checkout-common/src/icon.ts#L4 🙃

witoszekdev avatar Jul 21 '22 08:07 witoszekdev

Please consider this with the discussion if we should entirely remove MUI from Macaw

lkostrowski avatar Jul 25 '22 13:07 lkostrowski

Related https://github.com/saleor/macaw-ui/issues/157

lkostrowski avatar Jul 29 '22 05:07 lkostrowski

It's been decided: https://github.com/saleor/macaw-ui/issues/157 RFC is in progress.

typeofweb avatar Nov 02 '22 19:11 typeofweb