saleor
saleor copied to clipboard
Published
20 hours ago •
saleor
saleor
Add transaction action
Sorry for the big amount of lines. I didn't know how to split it with sense. The changes introduced in the PR:
- added new webhook
transaction-request - connect the new webhook with mutation
transactionRequestAction - added celery task to trigger transaction-request webhook. It is SYNC webhook that is called in celery task.
- added
causefield toTransactionEvent
Note:
- I am aware of
pytest.skipandFIXMElabels, I will handle it in future PRs as I didn't want to push more changes directly to this PR. - All migration files will be collapsed before merging the final feature branch (so don't worry if something can be handled in single migration instead of many).
Impact
- [ ] New migrations
- [ ] New/Updated API fields or mutations
- [ ] Deprecated API fields or mutations
- [ ] Removed API types, fields, or mutations
- [ ] Documentation needs to be updated
Pull Request Checklist
- [ ] Privileged queries and mutations are guarded by proper permission checks
- [ ] Database queries are optimized and the number of queries is constant
- [ ] Database migration files are up to date
- [ ] The changes are tested
- [ ] GraphQL schema and type definitions are up to date
- [ ] Changes are mentioned in the changelog
Here is the report for 3afab14c09a207550032e9df4c3cfdb1db3bea2c (saleor:add-transaction-action) Missing base report (5191b69db94a22063e787fabca29cdd932e83dbb). The results couldn't be compared.
No differences were found.
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
addresses for federation query count 9 9 2
customers query 48 48 0
delete staff members 39 39 1
query staff user 18 18 3
staff create 23 23 3
staff update groups and permissions 36 36 5
users for federation query count 8 8 3
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
groups for federation query count 5 5 2
permission group create 21 21 2
permission group delete 22 22 3
permission group query 7 7 0
permission group update 37 37 1
permission group update remove users with manage staff 31 31 3
# saleor.graphql.appbenchmarks app extensions
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
app extensions 15 15 0
app extensions with filter[filter0] 14 14 0
app extensions with filter[filter1] 10 10 0
app extensions with filter[filter2] 14 14 0
app extensions with filter[filter3] 10 10 0
# saleor.graphql.appbenchmarks apps
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
apps for federation query count 9 9 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
attribute translation 6 6 0
attribute value translation 26 26 0
query attribute 6 6 0
query attributes 8 8 0
# saleor.graphql.channelbenchmark channel
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
channels query 5 5 0
# saleor.graphql.channelmutations channel update
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
channel update mutation remove warehouse 38 38 6
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
add billing address to checkout 67 67 10
add checkout lines 67 67 10
add checkout lines with external shipping 168 168 67
add checkout lines with reservations 142 142 51
add delivery to checkout 65 65 9
add shipping to checkout 76 76 15
checkout email update 34 34 1
checkout payment charge 47 47 16
checkout shipping address update 70 70 8
checkout voucher code 85 85 16
complete checkout 177 177 36
complete checkout preorder 196 196 47
complete checkout with digital line 237 237 62
complete checkout with out of stock webhook 179 179 36
complete checkout with single line 179 179 36
create checkout 78 78 11
create checkout with reservations 138 138 30
customer complete checkout 198 198 46
customer complete checkout for cc 179 179 35
update checkout lines 60 60 10
update checkout lines with reservations 149 149 58
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
user checkout details 53 53 6
user checkout details with tax app 46 46 3
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
sales query with channel slug 19 19 0
sales query withot channel slug 18 18 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
vouchers query with channel slug 19 19 0
vouchers query withot channel slug 18 18 0
# saleor.graphql.giftcardbenchmark gift card mutations
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
create never expiry gift card 26 26 4
gift card bulk activate by staff 16 16 3
update gift card 36 36 4
# saleor.graphql.giftcardbenchmark gift card queries
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
filter gift cards by products 14 14 3
filter gift cards by tags 12 12 3
filter gift cards by used by user 13 13 3
query gift card details 14 14 3
query gift cards 12 12 3
# saleor.graphql.orderbenchmark fulfillment
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
fulfillment query 9 9 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
fulfillment refund products order lines 54 54 2
fulfillment return products order lines 96 96 9
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
staff multiple draft orders 724 724 570
staff multiple orders 231 231 125
staff order details 65 65 9
user order details 63 63 10
# saleor.graphql.orderbenchmark order fulfill
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
order fulfill 17 17 3
order fulfill with gift cards 17 17 3
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
page types for federation query count 3 3 0
query page type 18 18 6
query page types 25 25 12
# saleor.graphql.paymentbenchmark payment transactions
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
payment transactions 49 49 20
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
categories children 3 3 0
categories for federation query count 3 3 0
category delete 82 82 17
category view 36 36 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
collection add products 36 36 6
collection bulk delete 48 48 8
collection view 6 6 0
collections for federation query count 7 7 2
create collection 36 36 5
delete collection 40 40 7
remove products from collection 33 33 6
retrieve collection channel listings 5 5 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
filter products by attributes 9 9 0
filter products by boolean attributes 19 19 0
filter products by gift card 11 11 1
filter products by numeric attributes 18 18 0
product create 73 73 8
product details 43 43 0
product translations 5 5 0
products for federation query count 6 6 2
products media for federation query count 5 5 0
products types for federation query count 2 2 0
retrieve channel listings 21 21 0
retrieve product attributes 9 9 0
retrieve product images 4 4 0
retrieve product media 4 4 0
retrive products with product types and attributes 7 7 0
update product 51 51 11
# saleor.graphql.productbenchmark product variant channel listing update
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
variant channel listing update 45 45 3
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
product variant bulk create 68 68 3
product variant create 76 76 5
products variants for federation query count 6 6 2
retrieve variant list 37 37 1
update product variant 76 76 9
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
product variants stocks create 26 26 4
product variants stocks create with single webhook called 25 25 4
product variants stocks delete by id 27 27 4
product variants stocks delete by sku 27 27 4
product variants stocks delete with out of stock webhook many calls 23 23 3
product variants stocks update by sku 28 28 4
product variants stocks update byid 28 28 4
query product variants stocks 10 10 0
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
vouchers query with channel slug 7 7 0
vouchers query without channel slug 7 7 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
retrieve shop 4 4 0
# saleor.graphql.warehousebenchmark stocks
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
stocks query 5 5 0
# saleor.graphql.webhookbenchmark webhook events
test name left count right count duplicate count
------------------------------------------------------------------------ ----------- ----------- ---------------
webhooks 9 9 0
![db-queries[bot] avatar](https://avatars.githubusercontent.com/in/59286?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #11263 (3afab14) into support-refund-for-transaction (5191b69) will decrease coverage by
0.18%. The diff coverage is85.19%.
@@ Coverage Diff @@
## support-refund-for-transaction #11263 +/- ##
==================================================================
- Coverage 93.65% 93.47% -0.19%
==================================================================
Files 658 693 +35
Lines 50679 53034 +2355
Branches 5645 5992 +347
==================================================================
+ Hits 47465 49574 +2109
- Misses 2097 2263 +166
- Partials 1117 1197 +80
| Impacted Files | Coverage Δ | |
|---|---|---|
| saleor/graphql/payment/dataloaders.py | 100.00% <ø> (ø) |
|
| saleor/order/actions.py | 92.27% <ø> (-0.60%) |
:arrow_down: |
| saleor/graphql/order/mutations/order_void.py | 80.95% <50.00%> (-11.91%) |
:arrow_down: |
| saleor/plugins/webhook/plugin.py | 62.15% <50.00%> (-0.43%) |
:arrow_down: |
| saleor/plugins/webhook/utils.py | 96.66% <75.00%> (-2.43%) |
:arrow_down: |
| saleor/plugins/webhook/tasks.py | 86.48% <75.34%> (-3.10%) |
:arrow_down: |
| saleor/payment/utils.py | 92.39% <86.95%> (ø) |
|
| saleor/graphql/core/utils/__init__.py | 100.00% <100.00%> (ø) |
|
| saleor/graphql/payment/mutations.py | 95.39% <100.00%> (ø) |
|
| saleor/graphql/tests/queries/fragments.py | 100.00% <100.00%> (ø) |
|
| ... and 54 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}