saleor-storefront icon indicating copy to clipboard operation
saleor-storefront copied to clipboard

[Accessibility] <ul> and <ol> must only directly contain <li>, <script> or <template> elements

Open michalina-graczyk opened this issue 4 years ago • 2 comments

What I'm trying to achieve

<ul> and <ol> must only directly contain <li>, <script> or <template> elements

Screenshots

Zrzut ekranu 2020-08-3 o 15 57 31

System information Operating system: MacOS Browser: Chrome v.84

Selector

.main-menu__right > ul .main-menu__user--active

Source code

<ul> <li class="main-menu__icon main-menu__user--active">

Description

Ensures that lists are structured correctly Ensures

  • elements are used semantically

    Recommendation to fix

    List element has direct children that are not allowed inside <li> elements List item does not have a <ul>, <ol> parent element

  • michalina-graczyk avatar Aug 03 '20 14:08 michalina-graczyk

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

    stale[bot] avatar Oct 03 '20 07:10 stale[bot]

    @patrys having searched for <(u|o)l> it seems that his has already been done since NavItem contains either li or ul and there rest have li children.

    hinogi avatar Oct 19 '21 17:10 hinogi