saleor-dashboard icon indicating copy to clipboard operation
saleor-dashboard copied to clipboard

Fluid layout width

Open lkostrowski opened this issue 1 year ago • 1 comments

What I'm trying to achieve

I want content to fit my screen size. I can have wide display and app that can fill that space.

Currently dashboard limits page wrapper on desktop to 1280px, that includes all routes

Describe a proposed solution

I'd introduce some entity called LayoutWidth with initially 2 options - "compact" & "fluid".

Compact can be controlled with fixed pixel width. Fluid can be max-width: 100%

I see some options:

  1. Have a global setting in configuration (that will require some persistence layer changes?)
  2. Have a visible "toggle" (eg in sidebar) to quickly switch layouts. Save it in local storage for entire dashboard
  3. Have a visible "toggle" like above, but per route. Store settings in local storage

I think opt 3 is best, because:

  1. Some routes might look bad on fluid, same look bad on fixed. I may want fluid apps, but a fixed catalog.
  2. Storing in local storage is MVP solution. Persistence isn't a problem because it's an exposed option
  3. We can easily upgrade local storage to server-persistent setting, after we hear from community

lkostrowski avatar Jul 27 '22 11:07 lkostrowski

@timuric this is PO decision. Also @Droniu suggested to make only apps page fluid.

lkostrowski avatar Jul 27 '22 12:07 lkostrowski

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 06 '22 12:12 stale[bot]

Closing, new issue here https://github.com/saleor/saleor-dashboard/issues/2648

lkostrowski avatar Dec 06 '22 12:12 lkostrowski