saleor-dashboard icon indicating copy to clipboard operation
saleor-dashboard copied to clipboard

Fix variant page crashing when multiple product images

Open devenvyas opened this issue 2 years ago • 3 comments

I want to merge this change because it fixes an issue where dashboard crashes on navigating to variant page if the product has more than 1 image.

Fixes issues - #1962

PR intended to be tested with API branch: 3.1.8

Pull Request Checklist

  1. [ ] This code contains UI changes
  2. [ ] All visible strings are translated with proper context including data-formatting
  3. [ ] Attributes [data-test-id] are added for new elements
  4. [ ] Changes are mentioned in the changelog
  5. [ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

devenvyas avatar Apr 06 '22 20:04 devenvyas

@patrys @Kjaroszew is there something needed to get the review process started? let me know!

devenvyas avatar Apr 10 '22 11:04 devenvyas

@devenvyas lifesaving fix. thank you!

RyanTamulevicz avatar May 11 '22 21:05 RyanTamulevicz

Hi, I'd do it myself but I don't have access - could you rebase your branch?

dominik-zeglen avatar May 20 '22 08:05 dominik-zeglen

Flow up to the previous message - could you rebase @devenvyas ?

andrzejewsky avatar Sep 30 '22 07:09 andrzejewsky

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 06 '22 12:12 stale[bot]