Sasha Kluger comments

Results 62 comments of


                                            Sasha Kluger

HIGH: [Polish] [$500] Broken message text in LHN when Inviting someone to room.

I'm not sure - in https://github.com/Expensify/App/issues/34175, @jasperhuangg said that we should not implement a front-end fix because it would break 1:1:1, but that may be a different front-end fix. @jasperhuangg...

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

Something is definitely wrong here, but I'm not sure what the expected behavior is. Should the system message show the admin's name, the workspace's name, or neither? I'm confident that...

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

I updated the expected behavior and actual behavior. Expected result is now: 1. The system message should always start with the action, not the actor, regardless of who is viewing...

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

@0xmiroslav hopefully one of the above proposals does the trick! Mind taking a look when you hae a chance?

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

@0xmiroslav friendly bump.

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

Oh good question. I think the answer is yes, but I'm going to double check in Slack.

[$500] Expense - System message for paid expense shows payer, while the copied content is workspace

Sorry, still discussing expected LHN behavior in Slack.

[$250] Workspace switcher - Workspace switcher reopens after selecting a workspace with keyboard

@situchan it looks like there are a few proposals. Do any of them look good to you?

[$500] Room - Room with long description can not be created

Our back-end `MAX_DESCRIPTION_LENGTH` is set to 500 characters (https://github.com/Expensify/Web-Expensify/blob/main/lib/Report.php#L704). I'll ask in Slack whether we want to shorten the front-end maximum or increase the back-end max: https://expensify.slack.com/archives/C066HJM2CAZ/p1707859355835099

[$500] Room - Room with long description can not be created

We'd like to go with the longer 1024 limit, which means this is a BE change. I've applied the internal label and will make the change myself since we're just...