media-controls icon indicating copy to clipboard operation
media-controls copied to clipboard
verified publisher icon sakithb

Drag Problem

Open oguzhaniptes opened this issue 1 year ago • 10 comments

Describe the bug I encountered the issue of the GNOME desktop crashing when I held down the extension while dragging it anywhere.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Topbar'
  2. Click on Extension'
  3. Drag to 'Enywhere'
  4. See error

Expected behavior Open media control panel.

Environment:

  • Distro: Arch Linux
  • GNOME version 46
  • Extension Version 2.0.1

oguzhaniptes avatar May 09 '24 12:05 oguzhaniptes

I cannot drag the extension anywhere ... Not sure how you manage that ... Can you record it and post here ?

ChrisLauinger77 avatar May 09 '24 12:05 ChrisLauinger77

I just clicked and dropped it somewhere. It's very strange, I discovered it by mistake

https://github.com/sakithb/media-controls/assets/53427115/5a6c0c61-c7f8-4a32-b964-bfc7b4324de8

oguzhaniptes avatar May 09 '24 13:05 oguzhaniptes

The scrolling is enabled. I tried it without scrolling. Nothing happenend ...

ChrisLauinger77 avatar May 09 '24 13:05 ChrisLauinger77

I have the same issue as oguzhaniptes. Any clicking and dragging causes it to crash.

chase1k avatar May 11 '24 18:05 chase1k

The crash logs point to this line, https://github.com/sakithb/media-controls/blob/eeb83ab018924850d22a444de6b457f119a075e4/src/helpers/shell/PanelButton.ts#L870

I don't have any idea what is going wrong here, but I will investigate later.

sakithb avatar May 19 '24 13:05 sakithb

I do not see any crash logs here ? But seems the device at index "tapAction.nTouchPoints - 1" is not there ? I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

ChrisLauinger77 avatar May 20 '24 07:05 ChrisLauinger77

I do not see any crash logs here ? But seems the device at index "tapAction.nTouchPoints - 1" is not there ? I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

I didn't post the logs here, but I was able to reproduce it on fedora.

sakithb avatar May 22 '24 06:05 sakithb

I C. Maybe trace out "tapAction.nTouchPoints" - I have the feeling it returns 0 under some cirumstances and then the -1 is not a good idea ...

ChrisLauinger77 avatar May 22 '24 07:05 ChrisLauinger77

Seems like that isn't the issue. I tried by clamping the no of points to always be 0 or greater. Even after commenting out that code, it still crashes. My guess this is an error in the implementation of tap action itself.

sakithb avatar Jun 19 '24 03:06 sakithb

Same here on Fedora 40 and 41 and seems to be the same issue as:

  • https://github.com/sakithb/media-controls/issues/164

As that is pretty much what I do with the mouse. Left click and hold on the bar and then just move the mouse around and the whole shell crashed and presents the login screen.

ramonsmits avatar Oct 29 '24 12:10 ramonsmits

This doesn't seem to reproducible on GNOME 48 anymore, can someone confirm?

sakithb avatar Jun 22 '25 05:06 sakithb

@sakithb No longer a thing on Fedora 42 / GNOME Shell 48.2 for Media Controls 2.1.0

ramonsmits avatar Jun 22 '25 13:06 ramonsmits

@sakithb No longer a thing on Fedora 42 / GNOME Shell 48.2 for Media Controls 2.1.0

Thanks. Closing.

sakithb avatar Jun 22 '25 13:06 sakithb