Saket Narayan

Results 163 comments of Saket Narayan

Bumping this again for visibility

It'd be nice to have this. I am trying to use this plugin in multiple modules with a single properties file.

Right, but `onDetachedFromWindow()` only gets called when the layout is being destroyed. This means that the app will continue to keep the player in memory even when it's in background.

Because Android sends a lowMemory callback only when it's **really** low in memory. Apps, as good citizens, should not consume memory when they are not being used. Exoplayer also suggests...

IMHO, the library should not be making this decision for the developer and should atleast let the developer change it :)

We'd like to add support for RTL but we don't have any plans for it right now.

Let's leave this open

I am not sure I understand this correctly. Are your views overlapping when some of them are set to visibility=gone? Can you share screenshots if possible?

Gotcha. Views with a visibility of `gone` are considered [to not have any position](https://github.com/cashapp/contour/blob/f61867d98004d3fa28fcdf2dda781f1e0c99a219/contour/src/test/kotlin/com/squareup/contour/ContourTests.kt#L332:L348), i.e., `0, 0`. I think your best bet is to use conditions inside your axis solvers....