Sotonye Atemie

Results 77 comments of Sotonye Atemie

Oh, I just realized @Veratil mentioned the same thing above me previously, lol.

I have doubts about Windows compatibility and the use of `std::string`/`std::string_view` here. Might be more useful to utilize the `std::filesystem` library here (if we were to disregard the CI).

> I would argue the other way - the aim is eventually to remove Qt from the core, so the default choice should be to use UTF-8-encoded `std::string`s, with `QString`s...

> I just removed `basePrefixQString` entirely, which wasn't difficult to do since it hardly had any usage outside of `PathUtil` internally. I also clarified that the new functions use UTF-8....

I'm going to try and remove libsamplerate from this as well and use the functions within `interpolation.h`. I also don't know if we should even have a linear option anymore,...

Closing. Tried to eat more than I can chew here maybe. I honestly consider this PR an experiment. I think I did discover some benefits that are worthwhile here, but...

> MinGW-w64 include support for it via a Win32 port of pthreads. That's something we should look into. I was looking into this, but couldn't confirm that I can compile...