Sotonye Atemie
Sotonye Atemie
> I like the simplicity of the DataFileUpgrade class. It's straight forward and provides useful helper methods. It should even be possible to implement the UpgradeContainer schema with it if...
> But how would the user of this class, i.e. DataFile, know where to start in the list of the returned functions? Let's say my stored file is in the...
Closing this since the author has taken some time off from this project, and it doesn't seem like much progress will be made. If there are objections to closing, I...
> > Just a few formatting changes and readability enhancements. > > How about deleting the underscore in function parameters? At least in the .h file, where the variable is...
> I'd prefer doing that kind of stuff in a separate PR, not only removing leading underscores but also changing parameter names to something more expressive than the 1-2 letter...
Sorry, forgot about this. I saw a couple of problems with this that I wanted to mention. Give me a second.
Had a feeling I would break build..., sorry, just one second.
I'm going to push my fixes directly here since its easier (and safer) compared to reviewing it on Github again.
I cant say I'm a fan of the inheritance to `std::array`. I would prefer composition over inheritance and move `sampleFrame` into its own file. Also use the UpperCamelCase style as...
> On one hand we should get rid of the QFile usage here, but the bug was because CMake didn't replace the DLL as expected. So I believe the use...