Sotonye Atemie

Results 77 comments of Sotonye Atemie

IIRC, I believe the `updateFaders` function was throwing data races all the time on ThreadSanitizer. Maybe #6839 will fix this? Not too sure, but there's a good enough reason to...

Closing in favor of #7168 (apologies for having you go through all of that, but a more proper solution seems to have been found).

Fixed this for you (not sure why I needed to do it twice). ~I'm a bit confused on why we need the volume knob type. Shouldn't gain knobs just be...

Could you replace #6962 with #6985? I consider that whole PR a regression in and of itself (besides the addition of more specific filters and an interface for threaded searching),...

I tested this with ThreadSanitizer and compared the behavior for both the master branch and #6881 with a sample track. Whats similar is the occasional data race on calls to...

> I'd argue that build/install directories are rather a personal preference whereas the .vscode ignore benefits all people who use Visual Studio Code as their IDE. So in my opinion...

> We discussed the desired approach to `.gitignore` a while back, and concluded that each user should put their own IDE files and folders in `.git/info/exclude` locally. I'll try to...

> But it really doesn't hurt to put some defaults in there does it? What issue will be caused by adding things like .vs and .vscode to the ignore list?...

Thoughts: * I like the new inheritance hierarchy, where we have a base class ``DataFileUpgrade`` and specific upgrades can inherit that. * If we go with this approach: * I...

Thoughts and my design idea (subject to change, feel free to let me know what you think): * ``UpgradeContainer`` would be an abstract class that contains mainly a pure virtual...