sakai icon indicating copy to clipboard operation
sakai copied to clipboard

SAK-49119 Samigo various ui display improvements

Open hornersa opened this issue 1 year ago • 2 comments

With this proposed fix, I use b5 classes where possible to fix spacing issues; however, there are some exceptions where extant element selectors allow for new CSS statements in _samigo.sass to resolve issues more efficiently (i.e., without having to modify multiple JSP templates).

For the delivery of question types (e.g., for taking or previewing assessments), I also remove line break elements (
) and non-breaking space entities ( ) that have been used for presentation logic.

In the corresponding jira, I have attached 46 screenshots: 23 screenshots are prefixed with “Issue” to depict UI issues within this jira’s scope. They also include numbers and sometimes letters for easier reference with respect to the General > Description in the jira. The other 23 screenshots are prefixed with “Fix” and the same numbering/lettering scheme. I recommend downloading the attached screenshots to your OS to more easily sort the filenames and compare the “before” (Issue) and “after” (Fix) pics.

The code conflict associated with this PR pertains to fixes for S2U-12 5.1.1.8 that were merged into master after I had already branched from master to work on this (SAK-49119) branch. Note that in samigo/samigo-app/src/webapp/jsf/delivery/item/deliverCalculatedQuestion.jsp, the element with id="feedSC" currently has value="#{question.feedbackValue}". While appropriate for 24.x, I assume the value should instead be "#{question.feedback}” if/when merged for 23.x.

hornersa avatar Aug 02 '23 21:08 hornersa

You are right @hornersa with this comment

I assume the value should instead be "#{question.feedback}” if/when merged for 23.x.

jesusmmp avatar Aug 08 '23 15:08 jesusmmp

@hornersa can you rebase this PR as it has conflicts

ern avatar Sep 20 '23 15:09 ern

I'm willing to review and test if you update this PR

ottenhoff avatar Mar 19 '24 16:03 ottenhoff